Make all overloads of ArrayLiteral#[] return nil on out of bounds#16453
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Dec 11, 2025
Merged
Conversation
Member
|
Sorry, this PR slipped through my review list. The proposal sounds good. I suppose the rule of thumb is that methods in macro land should generally behave similar to the equivalents in Ruby. Even more, in macro land we couldn't even rescue an exception. So raising is not very useful except for really unrecoverable errors. It aborts the entire compilation. Returning |
straight-shoota
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single-index overload in the macro language has always behaved like
#[]?in non-macro code, so I don't think there is any particular benefit in making both the range overload and the start + count overload both raise on out-of-bounds start indices.This actually applies to
TupleLiteralas well.