Build compiler with -Dexecution_context#16447
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Dec 2, 2025
Merged
Build compiler with -Dexecution_context#16447straight-shoota merged 2 commits intocrystal-lang:masterfrom
-Dexecution_context#16447straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
Collaborator
Author
|
No, both builds behave the same, just sometimes we get a lucky run with less of everything (but wall time). Maybe there could be some profiling to understand how to improve efficiency. |
straight-shoota
approved these changes
Nov 28, 2025
Contributor
|
What command(s) do you use to benchmark it? When I try it seems to spend a miniscule part in multithreaded code, but perhaps I'm doing something wrong. |
Collaborator
Author
|
I use $ make release=1
$ rm -rf ~/.cache/crystal
$ rusage make -BIt doesn't spend much time in MT, but it uses lots of cores and CPU time adds up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We just enabled MT in #16380 but we can go further and enable execution context as suggested in the PR, by merely resizing the default context to the default workers count.
Also changes the default
--threadsvalue to also be the default workers count, which isCRYSTAL_WORKERSwhen specified and valid, and defaults to the number of available logical CPUs instead of being hardcoded to 4 threads (default forpreview_mt) or 8 forked processes (arbitrary number).It might be faster, on my computer recompiling Crystal went from ~17s to ~15s but your mileage may vary.