Add #unshift, #pop and #pop? to Crystal::PointerLinkedList#16287
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Oct 30, 2025
Conversation
Collaborator
Author
|
This patch has been sitting in a local branch for many months, now 😅 |
straight-shoota
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds methods to add and remove from any end of the list, while the current implementation only allows a FIFO behavior (add to tail, remove from head).
For example in the fdlock pull request I'd like to add new waiters to tail but add woken waiters to head (to give them some edge).