Loosen type restrictions in StaticFileHandler helper methods from File to IO#16238
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Oct 23, 2025
Conversation
…file_full of StaticFileHandler to IO
|
|
||
| private def serve_file_range(context : Server::Context, file : File, range_header : String, file_info) | ||
| # *io* should be seekable, that's implement #seek method | ||
| private def serve_file_range(context : Server::Context, io : IO, range_header : String, file_info) |
Member
There was a problem hiding this comment.
suggestion: Maybe it would be better to keep the parameter name file? It aligns well with the method name. Conceptually, we're serving a file. It might just have a representation that's different from the File type.
Ditto below.
straight-shoota
approved these changes
Oct 20, 2025
ysbaddaden
approved these changes
Oct 21, 2025
StaticFileHandler helper methods from File to IO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
file : Fileparameter toio : IOin private methodsStaticFileHandler#serve_file_rangeandStaticFileHandler#serve_file_full#serve_file_rangeto document thatiois supposed to be seekableCloses #15817