Add String#each_line parameter remove_empty#16232
Merged
straight-shoota merged 5 commits intocrystal-lang:masterfrom Nov 15, 2025
Merged
Conversation
Contributor
Author
|
I am concerned about handling "\n" lines when given |
Collaborator
|
The line itself is still empty? |
Member
straight-shoota
left a comment
There was a problem hiding this comment.
remove_empty applies a filter, chomp defines how the items are presented.
The empty line filter should not be affected by whether non-empty lines end with a NL character or not.
Contributor
Author
Confusion that may happen is what is filtered with the It seems logical to apply the filter to lines, that's a "\n" line will be filtered out regardless of the |
straight-shoota
approved these changes
Oct 21, 2025
String#each_line
ysbaddaden
approved these changes
Nov 13, 2025
String#each_lineString#each_line parameter remove_empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
remove_emptyparameter for methoddef each_line(chomp : Bool = true, & : String ->) : Nilremove_emptyparameter for methoddef each_line(chomp = true)Closes #15149