Skip to content

Revert type restriction for IO#read_bytes#16231

Merged
straight-shoota merged 1 commit intocrystal-lang:release/1.18from
straight-shoota:revert/type-restriction-io-read_bytes
Oct 20, 2025
Merged

Revert type restriction for IO#read_bytes#16231
straight-shoota merged 1 commit intocrystal-lang:release/1.18from
straight-shoota:revert/type-restriction-io-read_bytes

Conversation

@straight-shoota
Copy link
Member

Resolves #16230

@straight-shoota straight-shoota self-assigned this Oct 18, 2025
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:files kind:regression Something that used to correctly work but no longer works labels Oct 18, 2025
@ysbaddaden ysbaddaden added this to the 1.18.2 milestone Oct 19, 2025
@straight-shoota straight-shoota changed the base branch from master to release/1.18 October 19, 2025 18:08
@straight-shoota straight-shoota force-pushed the revert/type-restriction-io-read_bytes branch from f6a98c8 to 974a020 Compare October 19, 2025 18:09
@straight-shoota
Copy link
Member Author

I rebased onto release/1.18 to avoid backporting. We'll merge release/1.18@1.18.2 into master later.

@straight-shoota straight-shoota merged commit ba13db6 into crystal-lang:release/1.18 Oct 20, 2025
39 checks passed
@straight-shoota straight-shoota deleted the revert/type-restriction-io-read_bytes branch October 20, 2025 19:34
@rosskelvin111-glitch

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:stdlib:files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return type restriction of IO#read_bytes is too strong

3 participants