Support large JSON files#16211
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Oct 19, 2025
Merged
Conversation
Use i64 internally for line/column numbers in JSON documents. To avoid breaking changes, existing accessors convert to i32, raising on overflow. New i64 accessors are added, marked experimental, and used internally. Addresses crystal-lang#12946
ysbaddaden
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use i64 internally for line/column numbers in JSON documents. To avoid breaking changes, existing accessors convert to i32, raising on overflow. New i64 accessors are added, marked experimental, and used internally.
fixes #12946
See #16144 which was the original PR, which was mis-merged and reverted.