Guess instance variable types from global method calls#16119
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Sep 8, 2025
Merged
Guess instance variable types from global method calls#16119straight-shoota merged 1 commit intocrystal-lang:masterfrom
straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
|
The change looks good, my only concern here would be introducing compiler performance regressions which is the reason why the compiler's type inference capabilities were intentionally reduced many years ago |
Member
|
@mverzilli This doesn't add any more complexity than what's already there. It just adds the same logic we already have for calls to class method with explicit receiver to apply to calls to top-level methods with explicit namespace indicator ( |
straight-shoota
approved these changes
Sep 3, 2025
mverzilli
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the following to compile:
The call needs to be global; other than that, type guessing for top-level methods has the same limitations as for class methods.
Perhaps this would also apply to non-global calls as long as
Barand its ancestors do not define#foo?