Expand empty (Named)TupleLiteral to (Named)Tuple.new instead of {}#16108
Merged
straight-shoota merged 5 commits intocrystal-lang:masterfrom Aug 25, 2025
Merged
Conversation
Contributor
|
These type names must be global. |
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
Contributor
Author
Oh.. Hm. I though this was a low hanging fruit for me after digging around in code. 🙃 Trying to figure out what this means. Can you elaborate? |
Member
|
Global just means adding a This avoids mistakes if a |
Contributor
Author
Ah, right. Of course! |
Member
|
The specs need the global path as well. |
Contributor
Author
On it! A little bit to trigger happy 😬 |
straight-shoota
approved these changes
Aug 22, 2025
mverzilli
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes crystal/crystal-lang#16105
(But not #16105 (comment))