Skip to content

Remove NOERROR from LibXML default options#16103

Merged
straight-shoota merged 6 commits intocrystal-lang:masterfrom
straight-shoota:fix/libxml-noerror
Aug 26, 2025
Merged

Remove NOERROR from LibXML default options#16103
straight-shoota merged 6 commits intocrystal-lang:masterfrom
straight-shoota:fix/libxml-noerror

Conversation

@straight-shoota
Copy link
Member

Resolves #16090

@straight-shoota straight-shoota self-assigned this Aug 20, 2025
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:serialization labels Aug 20, 2025
@straight-shoota straight-shoota changed the title Trigger XML CI job on changes to XML specs Remove NOERROR from LibXML default options Aug 20, 2025
@straight-shoota
Copy link
Member Author

straight-shoota commented Aug 20, 2025

Windows CI is failing 🤔 Windows uses version 2.13.6, while the version specific test on Linux uses 2.13.8. Is the change between those releases...? https://gitlab.gnome.org/GNOME/libxml2/-/compare/v2.13.6...v2.13.8?from_project_id=1665
I understand the break should be with 2.13.0 already.

@HertzDevil
Copy link
Contributor

We don't set %LIBXML_VERSION% and there is no pkg-config, meaning the version defaults to 2.9.0 on MSVC. We should probably follow OpenSSL and LLVM here and create a local lib\libxml_VERSION file

@straight-shoota straight-shoota added this to the 1.18.0 milestone Aug 23, 2025
@straight-shoota straight-shoota merged commit ba25f92 into crystal-lang:master Aug 26, 2025
44 checks passed
@straight-shoota straight-shoota deleted the fix/libxml-noerror branch August 26, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:serialization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XML.parse no longer reports errors by default on libxml2 2.13.0 or above

4 participants