Fix fcntl reference for fds[1] in socketpair setup#16072
Merged
straight-shoota merged 3 commits intocrystal-lang:masterfrom Aug 15, 2025
Merged
Fix fcntl reference for fds[1] in socketpair setup#16072straight-shoota merged 3 commits intocrystal-lang:masterfrom
fcntl reference for fds[1] in socketpair setup#16072straight-shoota merged 3 commits intocrystal-lang:masterfrom
Conversation
Member
|
This is probably not a real bug. It's not super clean, but semantically should be all right. Potentially we could avoid one syscall here: store |
Contributor
Author
|
Thanks @straight-shoota I have added the commit based on your suggestion. |
Collaborator
|
Nope, it's indeed a copy-pasta typo. The first commit was more correct (get flags from |
This reverts commit 9461701.
straight-shoota
approved these changes
Aug 13, 2025
fds[1] in socketpair setup
fds[1] in socketpair setupfcntl reference for fds[1] in socketpair setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
While reviewing Crystal’s implementation with AI, I came across a potential bug in the non-blocking setup of socketpair.
According to the AI, the issue is as follows:
Problem
On line 206, the code reads flags from
fds[0]when setting them forfds[1]:It should read the flags from
fds[1]itself:This affects only older systems without
SOCK_CLOEXECsupport, where the second socket may incorrectly inherit the first socket’s settings.I’m not an expert on sockets, so I can’t confirm this. If it’s incorrect, please close the PR. Thank you.