Lazily instantiate the event loop of isolated execution contexts#16063
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Aug 9, 2025
Conversation
An isolated context might not need an evloop and certainly doesn't need one to be started upfront. It can be lazily instantiated on demand. The fiber is isolated, so it doesn't need to bother with concurrency or parallelism issues, however the context must support two mechanisms to suspend the fiber/thread: wait on the event loop (when instantiated) and wait on a condition variable otherwise.
straight-shoota
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An isolated context might not need an event loop and certainly doesn't need one to be started upfront. We can delay its instantiation to when we need it.
The fiber is isolated, so it doesn't need to bother with concurrency or parallelism issues, however the context must support two mechanisms to suspend the fiber/thread: wait on the event loop (when instantiated) and wait on a condition variable otherwise.