You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't get why the new spec fails on Aarch64 CI and in the interpreter only. Aarch64 CI is the runs-on environment which uses a different base image than the hosted runners from GitHub. But interpreter specs should run in exactly the same environment as other jobs. 🤷
Even the guard to make sure the file isn't readable didn't help. The file has no permissions. Yet still, apparently the file handler can still read its contents. This is very weird.
At last, I added a File.read test in order to properly detect whether the file is actually readable. If anyone has any better idea, I'm happy for suggestions. Maybe we can introduce some other kind of error?
broken-symlink.txt is breaking Git on MSYS2, it should be created and deleted entirely within the new specs:
$ MSYS='winsymlinks:nativestrict' git restore --source=HEAD :/
error: unable to create symlink spec/std/data/static_file_handler/broken-symlink.txt: No such file or directory
(MSYS='winsymlinks:native' would successfully create an invalid WSL1 symlink using IO_REPARSE_TAG_LX_SYMLINK, which we don't want either.)
Also, why does the spec look for broken_symlink.txt with an underscore instead of a hyphen? Is this intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #15901