Refactor IO.pipe blocking mode#15823
Merged
straight-shoota merged 3 commits intocrystal-lang:masterfrom May 28, 2025
Merged
Conversation
Moves the creation of IO pipes to the event loop, so they decide to set the underlying file descriptor or handle to blocking or non blocking mode. This is further reflected by the read_blocking and write_blocking args that now default to nil, instead of false, so the event loop will use its own requirements. This is a delayed breaking change: the current event loops will all set O_NONBLOCK on the file descriptors, or FILE_FLAG_OVERLAPPED for IOCP, by default, but future event loops can break this assumption (io_uring).
e73ce90 to
0c0cf51
Compare
Collaborator
Author
|
Rebased to remove #15804 and ready for review. |
This was referenced May 26, 2025
straight-shoota
approved these changes
May 26, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the creation of IO pipes to the event loop, so they decide to set the underlying file descriptor or handle to blocking or non blocking mode.
This is further reflected by the
read_blockingandwrite_blockingargs that now default to nil, instead of false, so the event loop will use its own requirements.This is a delayed breaking change: the current event loops will all set
O_NONBLOCKon the file descriptors, orFILE_FLAG_OVERLAPPEDfor IOCP by default, but future event loops can break this assumption (i.e.io_uring).Related to #15685.
Builds on top to #15804.