Fix error message when PollDescriptor can't transfer fd#15663
Merged
straight-shoota merged 2 commits intomasterfrom Apr 15, 2025
Merged
Fix error message when PollDescriptor can't transfer fd#15663straight-shoota merged 2 commits intomasterfrom
PollDescriptor can't transfer fd#15663straight-shoota merged 2 commits intomasterfrom
Conversation
Removes the `BUG:` prefer in the RuntimeError message when we can't transfer a `fd` to another event loop. The prefix usually denotes a broken expectation in the stdlib implementation, which means the stdlib did a mistake and we shall fix it, but this isn't the case here. An example for a BUG is just a few lines above to catch trying to transfer to the _same_ event loop (it makes no sense).
straight-shoota
approved these changes
Apr 15, 2025
PollDescriptor can't transfer fd
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
BUG:prefer in the RuntimeError message when we can't transfer afdto another event loop.The prefix usually denotes a broken expectation in the stdlib implementation, which means the stdlib did a mistake and we shall fix it, but this isn't the case here.
An example for a BUG is just a few lines above to catch trying to transfer to the same event loop (it makes no sense).