Add explicit Crystal::EventLoop#reopened(FileDescriptor) hook#15640
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Apr 17, 2025
Merged
Conversation
Contributor
|
As it's a hook I'd suggest naming it |
Collaborator
Author
|
I tried |
Contributor
|
|
straight-shoota
approved these changes
Apr 15, 2025
Member
|
I think the method name is fine. Calling this methods signals to the event loop that a file descriptor was reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want to close the file descriptor after we reopened it. Instead, some event loops want to resume the pending operations on the old file descriptor, so they can be restarted on the new file descriptor and at worst wait on the new one.
The proposed
#reopened(FileDescriptor)method explicits this difference in intended behavior.It doesn't change anything for the current event loops, but io_uring for example can close asynchronously so we must make the distinction, because we definitely don't want to close after reopen 😅
Another pull request will propose to move the actual close to the EventLoop so the
#close(io)method will do what it's supposed to do (close the FileDescriptor / Socket).Extracted from #15634