Retain original location for errors in included, extended hooks#13261
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Nov 28, 2025
Merged
Conversation
This was referenced Apr 1, 2023
742a2c4 to
5d4d93e
Compare
Member
Author
|
This is good for a review now. I think it makes sense we show the location of include/inherit that caused the error as the first frame. This way you know the specific context the error is in and could |
straight-shoota
approved these changes
Nov 26, 2025
ysbaddaden
approved these changes
Nov 27, 2025
included, extended hooks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #13260.
Resolves #7394
Before:
After:
I'd like to have this one pointing at
Fooitself vsinclude, but not sure how to do that. Can save it for another PR I guess.Before:
After:
Before:
After:
EDIT: Actually I'm not sure what the more proper error line is. E.g. is it pointing to the actual error if there isn't a specific node, or should it continue to be
include Foo, but with the^pointing at the actual module name like the OP described?