Conversation
Contributor
|
Thank you very much for fix this so quickly! I was just thinking about looking at the code and try make a PR ... |
Contributor
|
Just for mention, I saw you do some delete op in the File and Memory store impl methods, so, for the third-party store impl, maybe need do same changes? Anyway, I thought the #keys method always return the correct Set because we do the select on it. |
Member
Author
|
@zw963 I’m not sure. At least with the Redis cache I primarily use, there’s no need for a delete operation since key expiration is handled by Redis itself. Additionally, it’s technically not feasible for Redis cache implementation to return all cached keys. And frankly, it’s unnecessary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40