Make httpSafePort work as expected when httpSafeOrigin is set#1514
Make httpSafePort work as expected when httpSafeOrigin is set#1514dullbananas wants to merge 1 commit intocryptpad:stagingfrom
Conversation
|
Hello, can you please rebase your branch on |
|
Thanks a lot @dullbananas! |
|
Hello, Reading about your proposed changes with our lead developer, we understand there is a misunderstanding. While I will try to rephrase the explicative sentence as best as I can in the Then you'll need something to emulate the other origin, here comes In any other case, where you have 2 domains, you do not need |
|
I'm using a remote development environment where the URL used in the local browser to access the ports is more like 3000.example.com and 3001.example.com |
|
If you have 2 subdomains it's fine, it's the same. You don't need
You don't need anything else. |
|
That's not true. Setting httpSafeOrigin causes the server to not use port 3001, which causes 3001.example.com to not exist. |
Fixes #907
Required for using a separate sandbox origin in a remote development environment, which I need for reproducing #973