Fix gixy warnings regardding add_header in nginx example config#1213
Fix gixy warnings regardding add_header in nginx example config#1213martinetd wants to merge 1 commit intocryptpad:stagingfrom
Conversation
4f7916b to
78797af
Compare
|
Note that the stray '^' is already fixed in 5.4.1 |
gixy warns about add_header: add_header in a sublevel drops all headers set at parent level, see this link for details: https://github.com/yandex/gixy/blob/master/docs/en/plugins/addheaderredefinition.md * /api/ location was setting CORP/COEP to the same value as server level, just drop the add_header calls there * blob/block OPTIONS was missing dropping some headers, repeat the ones from top level Fixes: cryptpad#604
Ah, figured it couldn't be broken for long but I probably should have checked :) I've rebased and remved this part. |
78797af to
ca850ba
Compare
|
Hello, Thanks for your contribution, we tested your changes and we have a few issues with them. Mainly, duplicating all headers, that we know from experience that can cause issues with some web browsers. We won't be merging your proposed changes but instead will be proposing a much more simpler Nginx example file which will pass all requests to Node directly: Thanks for your interest anyway! |
|
Oh, so requests going to node should either add a bunch of proxy_hide_header, or the behaviour of dropping some headers from nginx was actually useful... I wonder if there's a way to explain that to gixy.. Well, won't be a problem with the new config anyway, thanks. I'll test a basic nginx config as I don't need any performance on my end (feeling it's a bit of a shame to not at least serve blocks and the dozens of js files directly, but won't matter much to me) |

Fixes: #604