Skip to content

Problem: mempool test is not stable#664

Merged
mmsqe merged 4 commits intocrypto-org-chain:mainfrom
mmsqe:mempool-test
Aug 23, 2022
Merged

Problem: mempool test is not stable#664
mmsqe merged 4 commits intocrypto-org-chain:mainfrom
mmsqe:mempool-test

Conversation

@mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Aug 23, 2022

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

close: #649

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@mmsqe mmsqe marked this pull request as ready for review August 23, 2022 01:17
@mmsqe mmsqe requested a review from a team as a code owner August 23, 2022 01:17
@mmsqe mmsqe requested review from adu-crypto and yihuang and removed request for a team August 23, 2022 01:17
Copy link
Contributor

@adu-crypto adu-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM

Copy link
Contributor

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't cover up the failure of the filter API by change the test, it defeats the purpose of the test case, right?
we should fix the root cause directly.

Copy link
Contributor

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmsqe mmsqe enabled auto-merge (squash) August 23, 2022 07:41
@mmsqe mmsqe merged commit 6d14b41 into crypto-org-chain:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem: mempool integration tests are not stable

3 participants