This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Problem: latest zeroize crate compilation fails (#127)#145
Merged
tomtau merged 1 commit intocrypto-com:masterfrom Jun 14, 2019
Merged
Problem: latest zeroize crate compilation fails (#127)#145tomtau merged 1 commit intocrypto-com:masterfrom
tomtau merged 1 commit intocrypto-com:masterfrom
Conversation
Solution: upgraded secp256k1 fork -- it merged changes from upstream rust-secp256k1: recovery module is now feature guarded we may consider removing it and switching to plain ecdsa
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=========================================
Coverage ? 80.19%
=========================================
Files ? 80
Lines ? 7224
Branches ? 0
=========================================
Hits ? 5793
Misses ? 1431
Partials ? 0
|
Collaborator
|
ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: upgraded secp256k1 fork
-- it merged changes from upstream rust-secp256k1: recovery module is now feature guarded
we may consider removing it and switching to plain ecdsa