Make response fields configurable to reduce trusted computing base#23
Merged
Conversation
Add response.includeLogResponses (default: true), response.includeSCTList (default: false), and response.produceFinalTBSCert (default: false) config options to control which fields are included in submission responses. Previously, finalTBSCertB64 and ctlint were always returned for precertificate submissions. As noted by Andrew Ayer, a CA that blindly signs the returned TBSCertificate is trusting ctsubmit with its signing key's output. These fields are now opt-in. Add sctListB64 response field (opt-in) containing the pre-marshaled TLS-encoded SCT list, to assist CAs in constructing the final TBSCertificate themselves. Validate on startup that at least one response field is enabled. Update REST API docs, OpenAPI spec, and HTML rendering accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add response.includeLogResponses (default: true), response.includeSCTList (default: false), and response.produceFinalTBSCert (default: false) config options to control which fields are included in submission responses.
Previously, finalTBSCertB64 and ctlint were always returned for precertificate submissions. As noted by Andrew Ayer, a CA that blindly signs the returned TBSCertificate is trusting ctsubmit with its signing key's output. These fields are now opt-in.
Add sctListB64 response field (opt-in) containing the pre-marshaled TLS-encoded SCT list, to assist CAs in constructing the final TBSCertificate themselves.
Validate on startup that at least one response field is enabled. Update REST API docs, OpenAPI spec, and HTML rendering accordingly.