feat(send signals): Handle machine preparation failed #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienloizelet
commented
Jun 21, 2024
|
|
||
| @abstractmethod | ||
| def get_machine_by_id(self, machine_id: str) -> MachineModel: | ||
| def get_machine_by_id(self, machine_id: str) -> Optional[MachineModel]: |
Collaborator
Author
There was a problem hiding this comment.
sql and mongodb storage implementation already returns Optional[MachineModel] ;
None is returned when the machine does not exist in database
julienloizelet
commented
Jun 21, 2024
| ) | ||
| if exc.response.status_code == 401: | ||
| if attempt_count >= self.max_retries: | ||
| self.storage.update_or_create_machine( |
Collaborator
Author
There was a problem hiding this comment.
I delete this piece of code, because we already update the machine in line 165 (after PR, line 157 before PR).
@rr404 : am I missing something ?
rr404
approved these changes
Jun 27, 2024
| total_sent += sent_signal_ids_count | ||
| self.logger.info(f"sent {sent_signal_ids_count} signals") | ||
| else: | ||
| self.logger.error( |
Collaborator
There was a problem hiding this comment.
Et du coup là on fait rien d'aute que log? sans essayer de lui choper un token ? on prend pour acquis que si ici elle pas a de token c'est qu'il y a eu un aute pb?
Y a t'il un risque qu'elle n'ai pas de token d'ailleurs ? vu que tu hadle le prepare qui fail
| ) | ||
| if exc.response.status_code == 401: | ||
| if attempt_count >= self.max_retries: | ||
| self.storage.update_or_create_machine( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30