Added MongoDB StorageInterface implementation #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienloizelet
requested changes
Mar 28, 2024
Collaborator
julienloizelet
left a comment
There was a problem hiding this comment.
Thanks for this PR.
| def __init__(self, connection_string="mongodb://127.0.0.1:27017/cscapi"): | ||
| try: | ||
| connect( | ||
| host="mongodb://127.0.0.1:27017/cscapi", |
Collaborator
There was a problem hiding this comment.
Here, I will modify with host=connection_string.
julienloizelet
approved these changes
Mar 29, 2024
Collaborator
julienloizelet
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this !
After merge, I will just try to add some github action tests for this mongo implementation and probably will modify slightly unit test to use some env connection_string.
Then, I will publish a new release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added implementation of MongoDB storage interface and its tests.
The new interface is not used by default but has an optional dependency that can be installed with
pip install cscapi[mongodb].The
get_signalsmethod has been hard to implement with MongoDB, so if you see any improvements that can be done I will gladly accept them :)