feat: add source file existence validation to config lint#976
Merged
andrii-bodnar merged 1 commit intocrowdin:mainfrom Jan 21, 2026
Conversation
46db178 to
006e810
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #976 +/- ##
============================================
- Coverage 65.42% 65.30% -0.12%
Complexity 1671 1671
============================================
Files 244 244
Lines 6838 6860 +22
Branches 1033 1043 +10
============================================
+ Hits 4473 4479 +6
- Misses 1777 1787 +10
- Partials 588 594 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrii-bodnar
approved these changes
Jan 21, 2026
Member
andrii-bodnar
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the contribution @StanislavPlotnikov-inDriver!
Contributor
Author
|
@andrii-bodnar Hi! Could you please tell me when I can expect a release with this change? |
Member
|
Hi @StanislavPlotnikov-inDriver, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add source file existence validation to
crowdin config lintSummary
Add source file existence validation to
crowdin config lintcommand.Problem
When a developer deletes a Gradle module (or any source files), the Crowdin sync workflow fails because the source files specified in the configuration no longer exist. Currently, there's no way to detect this misconfiguration before running the actual sync.
Solution
The
config lintcommand now validates that source files/patterns specified in the configuration actually match existing files on the filesystem. If no files match a source pattern, the command reports an error.Changes
checkSourceFilesExist()method to validate source file patternserror.config.source_not_foundfor missing sources*.xml)**/*.xml)Test plan
crowdin config lintwith valid config — should passcrowdin config lintwith non-existent source path — should report errorcrowdin config lintwith glob pattern matching no files — should report error./gradlew test --tests "com.crowdin.cli.properties.*"