fix(pre-translate): align parameter validations with API#956
Merged
andrii-bodnar merged 2 commits intomainfrom Nov 25, 2025
Merged
fix(pre-translate): align parameter validations with API#956andrii-bodnar merged 2 commits intomainfrom
andrii-bodnar merged 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
============================================
+ Coverage 66.24% 66.30% +0.06%
Complexity 1669 1669
============================================
Files 243 243
Lines 6720 6720
Branches 1009 1007 -2
============================================
+ Hits 4451 4455 +4
+ Misses 1694 1692 -2
+ Partials 575 573 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yevheniyJ
reviewed
Nov 22, 2025
yevheniyJ
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove client-side validations for parameters that can now be used with any pre-translation method (duplicateTranslations, translateUntranslatedOnly).
Keep validation for translateWithPerfectMatchOnly as it remains TM-only per API documentation.
Note
Loosens pre-translate option checks to allow
duplicateTranslationsandtranslateUntranslatedOnlyfor all methods, while keepingtranslateWithPerfectMatchOnlyTM-only and removing obsolete error messages.--duplicate-translationsand--translate-untranslated-onlywith anymethodby removing MT-specific restrictions inPreTranslateSubcommand#checkOptions.--translate-with-perfect-match-onlyonly for TM by validatingmethod != TM→ error.error.pre_translate.duplicate_translationsanderror.pre_translate.translate_untranslated_onlyfrommessages.properties.error.pre_translate.translate_with_perfect_match_onlyand other existing messages unchanged.Written by Cursor Bugbot for commit 4be2a12. This will update automatically on new commits. Configure here.