Give some EC2 networking APIs a creation grace time#805
Closed
negz wants to merge 1 commit intocrossplane-contrib:masterfrom
Closed
Give some EC2 networking APIs a creation grace time#805negz wants to merge 1 commit intocrossplane-contrib:masterfrom
negz wants to merge 1 commit intocrossplane-contrib:masterfrom
Conversation
Per crossplane-contrib#802 there seems to be some lag between when some EC2 networking resources (RouteTables, InternetGateways) are created and when they actually show up in queries. This commit leverages crossplane/crossplane-runtime#280 to allow for this. Signed-off-by: Nic Cope <negz@rk0n.org>
2 tasks
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
Explicitly queue a reconcile request if a shared provider has expired
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes at least one variant of #802.
Closes #803.
Per #802 there seems to be some lag between when some EC2 networking resources (RouteTables, InternetGateways) are created and when they actually show up in queries. This PR leverages crossplane/crossplane-runtime#280 to allow for this.
I'm leaving this in draft for now because I want to manually test it a little more (and update the relevant unit tests).
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
See crossplane/crossplane-runtime#280.