Composition Function Events and Status Conditions#129
Merged
negz merged 1 commit intocrossplane:mainfrom Jun 28, 2024
Merged
Conversation
6 tasks
negz
reviewed
Mar 27, 2024
Member
negz
left a comment
There was a problem hiding this comment.
Some nitpicks/questions, but overall this looks good. Thank you!
99e0bda to
454fb81
Compare
negz
reviewed
Mar 28, 2024
Member
negz
left a comment
There was a problem hiding this comment.
Thanks @dalton-hill-0! One last comment, but this LGTM.
Holding off on approving for now until we get the equivalent c/c changes implemented.
154df9c to
d685d66
Compare
Member
|
@dalton-hill-0 This one could use a git history cleanup before I merge too. |
negz
approved these changes
Jun 27, 2024
Signed-off-by: Dalton Hill <dalton.hill.0@protonmail.com>
675e507 to
9de5311
Compare
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes Crossplane 5402
One-pager PR that documents this effort (Crossplane 5426)
Should be merged with Crossplane 5450
Additional changes: Adds some go packages to be included in the Make logic so that they get picked up by
make reviewable.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested