feat: enable namespaced references in generated resolvers#110
Merged
negz merged 1 commit intocrossplane:crossplane-v2from Jun 7, 2025
Merged
feat: enable namespaced references in generated resolvers#110negz merged 1 commit intocrossplane:crossplane-v2from
negz merged 1 commit intocrossplane:crossplane-v2from
Conversation
Signed-off-by: Jared Watts <jbw976@gmail.com>
5 tasks
negz
approved these changes
Jun 7, 2025
This was referenced Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR updates the resolver generator to factor in the namespace of the given instance for which references are being resolved. When a reference is going to be resolved during the reconciliation of a managed resource, the namespace of the instance will now be passed into crossplane-runtime's
Resolve()method, as part of theResolutionRequeststruct.Part of crossplane/crossplane#6381
Note the base branch for this PR is a new crossplane-v2 branch, not main - we can let this change bake in that v2 branch for a bit until it's time to ship v2.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
These changes have been tested as demonstrated in this demo repo: https://github.com/jbw976/demo-upjet-namespaced-refs