fix: generate *float64 with convert import path#102
Open
cristiGuranIonos wants to merge 1 commit intocrossplane:masterfrom
Open
fix: generate *float64 with convert import path#102cristiGuranIonos wants to merge 1 commit intocrossplane:masterfrom
cristiGuranIonos wants to merge 1 commit intocrossplane:masterfrom
Conversation
Signed-off-by: cristi <cristian.mihai.guran@ionos.com>
4266be4 to
5e59442
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Float64 pointer fields are not generated correctly using the latest version of corssplane-tools:
Example:
Where the import is :
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Replace in go.mod for
provider-upjet-ionoscloudwith the local copy with the changes. Test that the code is generated correctly.Ran tests in resolvers_test.go . These tests were failing before I made any changes:
rsp, err = r.Resolve(ctx, reference.ResolutionRequest{ - CurrentValue: convert.FromPtrValue(mg.Spec.ForProvider.CustomConfiguration), + CurrentValue: mg.Spec.ForProvider.CustomConfiguration, Extract: Configuration(), Reference: mg.Spec.ForProvider.CustomConfigurationRef, ... // 7 identical lines return errors.Wrap(err, "mg.Spec.ForProvider.CustomConfiguration") } - mg.Spec.ForProvider.CustomConfiguration = convert.ToPtrValue(rsp.ResolvedValue) + mg.Spec.ForProvider.CustomConfiguration = rsp.ResolvedValue mg.Spec.ForProvider.CustomConfigurationRef = rsp.ResolvedReferenceI fixed those errors, but maybe someone can take a closer look at that field.
Note: There is another solution to use
convertpath for bothIsPointerandIsFloatPointer, but I saw thatconvert.FromPtrValuein convert.go is deprecated in favor ofptr.Deref.