Correct Connector and Disconnector typos, add aliases to prevent breakage.#835
Merged
negz merged 2 commits intocrossplane:mainfrom May 19, 2025
Merged
Correct Connector and Disconnector typos, add aliases to prevent breakage.#835negz merged 2 commits intocrossplane:mainfrom
negz merged 2 commits intocrossplane:mainfrom
Conversation
…kage. Signed-off-by: Scott Nichols <n3wscott@upbound.io>
Signed-off-by: Scott Nichols <n3wscott@upbound.io>
negz
approved these changes
May 19, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
I noticed the word
ConnectorandDisconnectorwere misspelled with anervsor. Fixed that.I have added aliases for any corrected type or function with the limited exception of the following that require a bump to go v1.23+:
TypedNopDisconnecterTypedNopDisconnecterTypedExternalConnectDisconnecterFnsin Go v1.23+, generic aliases are allowed, but not in 1.22.
I have also build and ran the unit tests for this change replacing the package for:
Lastly, I moved the deprecated functions and types into their own file so we can clean it up easier. Possibly for v2?
I have:
earthly +reviewableto ensure this PR is ready for review.- [ ] Added or updated unit tests.- [ ] Linked a PR or a docs tracking issue to document this change.- [ ] Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.