Revert "chore: deprecate the reference pointer helper functions"#833
Merged
jbw976 merged 1 commit intocrossplane:mainfrom May 9, 2025
Conversation
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
df58586 to
79b8fcf
Compare
jbw976
approved these changes
May 9, 2025
Member
jbw976
left a comment
There was a problem hiding this comment.
LGTM @sergenyalcin, I agree with the conclusion in crossplane/crossplane-tools#106 (comment).
2 tasks
This was referenced May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #780
The details are in crossplane/crossplane-tools#106 and crossplane/crossplane-tools#103.
We observed behavioral differences between the
k8s.io/utils/ptrpackage and these helper functions. So, I am attempting to reverse this change and reintroduce them.Other references: grafana/crossplane-provider-grafana#282, crossplane-contrib/provider-upjet-gcp#779.
Please see @negz's guidance: crossplane/crossplane-tools#106 (comment)
After reintroducing these helpers, I will update my crossplane-tools PR.