Merged
Conversation
…ble coordinated condition updates Signed-off-by: Scott Nichols <n3wscott@upbound.io>
4 tasks
negz
reviewed
May 2, 2025
Member
negz
left a comment
There was a problem hiding this comment.
Lots of nits but I like the overall direction. Thanks!
Signed-off-by: Scott Nichols <n3wscott@upbound.io>
Signed-off-by: Scott Nichols <n3wscott@upbound.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Introduce a conditions package with a light weight manager to help enable coordinated condition updates. This will grow over time, for now the focus is just on helping make
observedGenerationpropagate to the condition that is being updated.Relates to #828
earthly +reviewableto ensure this PR is ready for review.- [ ] Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.