fix: order values in MultiResolutionResponse#802
Merged
jbw976 merged 1 commit intocrossplane:mainfrom Jun 9, 2025
Merged
Conversation
ed7979f to
7611fb7
Compare
negz
approved these changes
Jun 7, 2025
Member
|
Sorry for the super late review. This LGTM but looks like there's now a merge conflict. |
negz
reviewed
Jun 7, 2025
f284457 to
5d7b981
Compare
Signed-off-by: Guilhem Lettron <glettron@akamai.com>
5d7b981 to
d48e582
Compare
jbw976
approved these changes
Jun 9, 2025
| want: want{ | ||
| rsp: MultiResolutionResponse{ | ||
| ResolvedValues: []string{value2, value}, | ||
| ResolvedReferences: []xpv1.Reference{{Name: value2}, {Name: value}}, |
Member
There was a problem hiding this comment.
interesting that we don't seem to have had a test case already that returned multiple values - i guess if we did it would have been failing intermittently because we weren't using a stable sort order until this PR 🤓
Member
|
I think the check-diff step failed because this branch doesn't have #846, as shown in the compare. Will merge to main with this failure since it's fixed there. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Sort outputs from
ResolveMultiple.Fixes #803
I have:
earthly +reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.