feat: support additional management policy combination#788
Merged
turkenh merged 2 commits intocrossplane:mainfrom Feb 25, 2025
Merged
Conversation
Signed-off-by: Manish Kumar <mk14445@gmail.com>
dc9fcb1 to
32db6df
Compare
lsviben
requested changes
Feb 12, 2025
Contributor
lsviben
left a comment
There was a problem hiding this comment.
Firstly, sorry for waiting that long for a review, this slipped my mind and I got reminded just recently 🙏 .
The policies added make sense to me.
We need to add the unit tests in the right place to check the reconciler flow with the new policies.
Signed-off-by: Manish Kumar <mk14445@gmail.com>
lsviben
approved these changes
Feb 25, 2025
Contributor
lsviben
left a comment
There was a problem hiding this comment.
Looks good! Thanks @man-ish-k ! 🎉
turkenh
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add two new management policy combinations to support safer resource importing and external lifecycle management scenarios:
Import Mode: A new policy combination that allows safe importing of existing resources by only permitting observation and late initialization, without making any changes to the external resource.
[Observe, LateInitialize]External Lifecycle Management: A policy combination for resources whose lifecycle (creation/deletion) is managed outside of Crossplane, but allows Crossplane to make updates and track state.
[Observe, Update, LateInitialize]Fixes #681,
I have:
earthly +reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.