Fix unknown fields warnings and possibility to suppress finalizer ones#786
Merged
turkenh merged 2 commits intocrossplane:mainfrom Nov 5, 2024
Merged
Fix unknown fields warnings and possibility to suppress finalizer ones#786turkenh merged 2 commits intocrossplane:mainfrom
turkenh merged 2 commits intocrossplane:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR aims to clean up warnings observed in crossplane/crossplane#6043 by:
Suppressing "prefer a domain-qualified finalizer" until we properly migrate them to the suggested format.Together with the accompanying PR in Crossplane, I could validate that former warnings disappeared with the changes here.
This PR introduces a new package,warning, with thewarning.LoggingHandlerimplementing rest.WarningHandler interface. This supports deduplication just like the current handler Crossplane uses, but it also uses provided crossplane runtime logger so that warnings logged as structured logs* and also enables discarding logs matching provided regular expressions. I opted to put this into crossplane runtime since we may want to leverage it in other repositories, e.g. providers, as well.I have:
earthly +reviewableto ensure this PR is ready for review.Linked a PR or a docs tracking issue to document this change.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.