Give unstructured types their own DeepCopy methods#599
Merged
negz merged 2 commits intocrossplane:masterfrom Nov 13, 2023
Merged
Give unstructured types their own DeepCopy methods#599negz merged 2 commits intocrossplane:masterfrom
negz merged 2 commits intocrossplane:masterfrom
Conversation
Fixes crossplane/crossplane#4970 These types all embed *unstructured.Unstructured. If they don't implement their own DeepCopy methods, callers will end up calling those of the embedded *Unstructured. The result is that a deepcopy isn't a real copy - it's the wrong type (*unstructured.Unstructured). Signed-off-by: Nic Cope <nicc@rk0n.org>
phisco
approved these changes
Nov 6, 2023
pedjak
reviewed
Nov 6, 2023
Removes the tests - we don't need to test generated code. Signed-off-by: Nic Cope <nicc@rk0n.org>
pedjak
approved these changes
Nov 7, 2023
|
Successfully created backport PR for |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Will fix crossplane/crossplane#4970 (after runtime bump)
These types all embed *unstructured.Unstructured. If they don't implement their own DeepCopy methods, callers will end up calling those of the embedded *Unstructured. The result is that a deepcopy isn't a real copy - it's the wrong type (*unstructured.Unstructured).
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested