errors: add SilentlyRequeueOnConflicts#556
Merged
turkenh merged 2 commits intocrossplane:masterfrom Oct 2, 2023
Merged
Conversation
18e6832 to
7ae4423
Compare
2 tasks
lsviben
approved these changes
Sep 26, 2023
pkg/errors/reconcile_test.go
Outdated
Comment on lines
+1
to
+2
| // Copyright 2023 Upbound Inc. | ||
| // All rights reserved |
Contributor
There was a problem hiding this comment.
Should be the Crossplane copyright stuff here.
14bed81 to
f591d3b
Compare
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
f591d3b to
8333c5c
Compare
negz
approved these changes
Sep 28, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Example:
If the returned error is a (possibly wrapped) Kube conflict error, it is dropped (replaced with
nil) and the result is replaced with an immediate requeue.This way, the conflict errors, which are part of the Kube's optimistic concurrency protocol and not actual errors, do not show up as ugly backtrace in the logs.
Alternative way to use:
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Unit tested.