reconciler/managed: only debug log transient conflict errors#498
Merged
phisco merged 1 commit intocrossplane:masterfrom Aug 6, 2023
Merged
reconciler/managed: only debug log transient conflict errors#498phisco merged 1 commit intocrossplane:masterfrom
phisco merged 1 commit intocrossplane:masterfrom
Conversation
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
phisco
approved these changes
Aug 4, 2023
jbw976
reviewed
Aug 5, 2023
Member
There was a problem hiding this comment.
@sttts does this directly address crossplane/crossplane#2114 - "Suppress "object has been modified" warning events"? 🤔
ytsarev
approved these changes
Aug 5, 2023
Member
ytsarev
left a comment
There was a problem hiding this comment.
Nice! It will help to avoid confusion and heavily reduce the noise during debugging process 👍
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Conflict errors are transient in Kubernetes and completely normal. The right reaction is to requeue, but not record the object as error'ing or creating events.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested