Closed
Conversation
Signed-off-by: Nic Cope <negz@rk0n.org>
Collaborator
|
|
hasheddan
reviewed
Sep 19, 2019
Member
hasheddan
left a comment
There was a problem hiding this comment.
Leaving this in draft to start a discussion. We may want to consider updating the areas each maintainer is responsible for to better reflect the current state of the project.
Might also be interesting to assign maintainers to "subprojects" like the stacks and crossplane-runtime since those will likely start to be versioned / released at a different pace than core crossplane.
Member
Author
|
Closing in favor of #951. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Consider this a request to be a formal Crossplane maintainer. :) I believe I already have most of the responsibilities and rights of a senior maintainer per our Governance document.
Leaving this in draft to start a discussion. We may want to consider updating the areas each maintainer is responsible for to better reflect the current state of the project.
Tangentially, we're hitting the point that it would increase velocity to have more folks with permission to merge approved pull requests. @jbw976 suggested we consider adopting Rook's approver/reviewer policy, which I believe would address this in a fashion that is complimentary to my understanding of our current governance model.
Checklist
I have:
make reviewableto ensure this PR is ready for review.clusterrole.yamlto include any new types.