Skip to content

Remove .status.crossplane.connectionDetails from modern XR schema#6655

Merged
jbw976 merged 3 commits intocrossplane:mainfrom
jbw976:conform
Jul 26, 2025
Merged

Remove .status.crossplane.connectionDetails from modern XR schema#6655
jbw976 merged 3 commits intocrossplane:mainfrom
jbw976:conform

Conversation

@jbw976
Copy link
Copy Markdown
Member

@jbw976 jbw976 commented Jul 26, 2025

Description of your changes

This PR removes .status.crossplane.connectionDetails from the schema of modern XRs.

I have tested this with the latest v2 conformance tests from crossplane/conformance#31. The TestCompositeResourceDefinition* tests were failing because of this unexpected field and now they are happy.

❯ go test -v -run TestCompositeResourceDefinitionNamespace tests/*
=== RUN   TestCompositeResourceDefinitionNamespace
    apiextensions_test.go:82: Created XRD "namespaceconformances.test.crossplane.io"
=== RUN   TestCompositeResourceDefinitionNamespace/BecomesEstablished
    apiextensions_test.go:523: Testing that the XRD's Established status condition becomes 'True'.
    apiextensions_test.go:530: XRD "namespaceconformances.test.crossplane.io" is not yet Established
    apiextensions_test.go:539: XRD "namespaceconformances.test.crossplane.io" is Established
=== RUN   TestCompositeResourceDefinitionNamespace/CRDIsCreatedForXR
    apiextensions_test.go:99: Testing that the XRD creates a conformant CRD for its XR.
    apiextensions_test.go:569: XRD "namespaceconformances.test.crossplane.io" created a conformant XR CRD
=== NAME  TestCompositeResourceDefinitionNamespace
    apiextensions_test.go:85: Cleaning up XRD "namespaceconformances.test.crossplane.io".
    apiextensions_test.go:92: Deleted XRD "namespaceconformances.test.crossplane.io"
--- PASS: TestCompositeResourceDefinitionNamespace (10.08s)
    --- PASS: TestCompositeResourceDefinitionNamespace/BecomesEstablished (10.01s)
    --- PASS: TestCompositeResourceDefinitionNamespace/CRDIsCreatedForXR (0.04s)
PASS
ok  	command-line-arguments	10.492s

Fixes #6652

I have:

Need help with this checklist? See the cheat sheet.

jbw976 added 3 commits July 25, 2025 17:35
@jbw976
api: modern XRs do not have connection details
35676f3 
Signed-off-by: Jared Watts <jbw976@gmail.com>
@jbw976
chore: add a .gitignore section for AI tools
737301f 
Signed-off-by: Jared Watts <jbw976@gmail.com>
@jbw976
chore: automatic formatting updates for organizing imports
d9f1f5d 
Signed-off-by: Jared Watts <jbw976@gmail.com>
@jbw976 jbw976 requested review from a team and negz as code owners July 26, 2025 05:39
@jbw976 jbw976 requested a review from bobh66 July 26, 2025 05:39
@jbw976 jbw976 changed the title Conform Remove .status.crossplane.connectionDetails from modern XR schema Jul 26, 2025
bobh66
bobh66 approved these changes Jul 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@bobh66 bobh66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbw976 jbw976 merged commit 9fa5bc1 into crossplane:main Jul 26, 2025
25 checks passed
@jbw976 jbw976 mentioned this pull request Jul 26, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobh66 bobh66 bobh66 approved these changes

@negz negz Awaiting requested review from negz negz is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

XR schema should not have status.crossplane.connectionDetails

2 participants

@jbw976 @bobh66