Add a one-pager regarding controlled rollout of composition functions#6398
Add a one-pager regarding controlled rollout of composition functions#6398negz merged 2 commits intocrossplane:mainfrom
Conversation
Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
| For example, a user wishing to roll out a new version of | ||
| `function-patch-and-transform` to only certain XRs may install the function | ||
| using the following manifest: |
There was a problem hiding this comment.
one thing i didn't quite catch from the description of this scenario is how the user interacts with Function objects to create new revisions. For a given function, the user will only interact with a single Function object, right? i.e. If the user wants multiple revisions, they first create a Function object with .spec.package that points to version 1, then later on they update that same Function object to point to version 2. Along with that update, they would also add this alpha label at the same time. Is that right?
The example here was making me second guess that flow because the way its described here it sounds like to create a new revision/version, the user creates another new Function object - but I don't think that's right 🤔
There was a problem hiding this comment.
Your initial understanding is correct - the user updates the .spec.package (and any labels they want) in the existing object. I've updated the text in the example to clarify that.
There was a problem hiding this comment.
Awesome, thank you for making that workflow more clear here!
Agreed, I don't see any negative interaction. #4662 proposes another way to select composition revisions; with the change proposed in this PR those composition revisions may select function revisions, but there's no change to how composition revisions are selected. |
Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
9c802d1 to
5681480
Compare
|
Force pushed to pass the DCO check. |
Description of your changes
This one-pager proposes two changes that will allow Crossplane users to control rollout of composition function revisions:
Functionresource.Toward #6139
I have:
earthly +reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Followed the API promotion workflow if this PR introduces, removes, or promotes an API.