Make make run working with the latest changes#5745
Make make run working with the latest changes#5745ytsarev wants to merge 1 commit intocrossplane:masterfrom
make run working with the latest changes#5745Conversation
haarchri
left a comment
There was a problem hiding this comment.
lgtm ;)
related to https://gist.github.com/haarchri/6526d1738611cc79c04e88091dfe074a
* Make `make run` operable again to enable fast feedback dev loop * Retrieve TLS certificates from the runtime cluster secrets * Disable webhooks for local out-of-cluster scenario Signed-off-by: Yury Tsarev <yury@upbound.io>
|
I was planning to merge #5711 today, which removes the Makefile entirely. |
jbw976
left a comment
There was a problem hiding this comment.
Thanks for jumping on this quickly @ytsarev and getting a local dev experience working again 😉
Given the transition from make -> earthly, let's see what comes out of the discussion on #5711 (comment) before merging this effort, as it may just be entirely replaced 🙇♂️
| run: go.build | ||
| @$(INFO) Getting TLS certificates from the cluster... | ||
| @mkdir -p $(TLS_SERVER_CERTS_DIR) | ||
| @kubectl get secret crossplane-tls-server -n $(CROSSPLANE_NAMESPACE) -o jsonpath="{.data.tls\.crt}" | base64 --decode > "$(TLS_SERVER_CERTS_DIR)/tls.crt" |
There was a problem hiding this comment.
instead of directly invoking kubectl, I think you'd want to use $(KUBECTL) instead, so the cached tool/version is used instead of whatever is on your local machine 😉
|
if the Earthly is the way to go, I can reimplement it after the merge of #5711 |
|
Closing for now. Please do take a shot at porting this to Earthly, and let me know how you like working with it. Given we need to run Crossplane against a cluster, I'm wondering if this could be some argument to the |
Description of your changes
make runoperable again to enable fast feedback dev loopFixes #5636
I have:
make reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.