Proof-of-concept to plumb function results to claims #5523
Closed
negz wants to merge 4 commits intocrossplane:masterfrom
Closed
Proof-of-concept to plumb function results to claims #5523negz wants to merge 4 commits intocrossplane:masterfrom
negz wants to merge 4 commits intocrossplane:masterfrom
Conversation
6 tasks
Signed-off-by: Nic Cope <nicc@rk0n.org>
It's probably useful to let function authors influence the reason of events. We already let them influence the reason of conditions. Signed-off-by: Nic Cope <nicc@rk0n.org>
Signed-off-by: Nic Cope <nicc@rk0n.org>
We'll add SDK helpers so folks can just write them directly Signed-off-by: Nic Cope <nicc@rk0n.org>
Member
Author
|
The real implementation was done in #5450. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #5402
I don't intend to finish this and get it merged. I'm just using this PR to sketch out a direction for @dalton-hill-0 to consider as part of #5450.
This implements the design we sketched out in #5426.
I have:
make reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.