apiextensions/definition: fix leak of watch on composition revisions due to wrong referenced cache#5463
Closed
sttts wants to merge 3 commits intocrossplane:masterfrom
Closed
Conversation
…due to wrong referenced cache Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
…iggering composite reconciles Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
This reverts commit 53b143f. Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
3 tasks
Member
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR changes the triggering cache for
CompositionRevisionstoxrCache, i.e. the informer watchingCompositionRevisionsas long as the XR controller is running. Before this PR both life-cycles did not match and a trigger is never removing its event handler. Hence, this was leaking event handlers on the global manager cache.I have:
make reviewableto ensure this PR is ready for review.[ ] Added or updated unit tests.[ ] Added or updated e2e tests.[ ] Linked a PR or a docs tracking issue to document this change.[ ] Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.