Don't run Realtime Composition E2E tests in CI#5296
Merged
negz merged 1 commit intocrossplane:masterfrom Jan 27, 2024
Merged
Conversation
Per crossplane#5228 we know these tests fail most of the time. Running them on every CI job isn't helping catch anything we don't already know. It does make it harder to notice when other things fail, since we're becoming used to seeing the red x. I think we should disable these until they're less flaky. They're testing an alpha feature that is off by default. Signed-off-by: Nic Cope <nicc@rk0n.org>
jbw976
approved these changes
Jan 27, 2024
Member
jbw976
left a comment
There was a problem hiding this comment.
LGTM, I don't see realtime-compositions being tested on this PR, so looks like it works 😉
Contributor
|
👀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
I think we should disable these until they're less flaky. They're testing an alpha feature that is off by default.
Per #5228 we know these tests fail most of the time. Running them on every CI job isn't helping catch anything we don't already know. It does make it harder to notice when other things fail, since we're becoming used to seeing the red x.
I have:
make reviewableto ensure this PR is ready for review.Added or updated unit tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.