Recommend unwinding constant error string pattern#4515
Merged
negz merged 1 commit intocrossplane:masterfrom Feb 28, 2024
Merged
Recommend unwinding constant error string pattern#4515negz merged 1 commit intocrossplane:masterfrom
negz merged 1 commit intocrossplane:masterfrom
Conversation
cmpopts.EquateErrors in unit tests
cmpopts.EquateErrors in unit tests
phisco
reviewed
Aug 26, 2023
|
Crossplane does not currently have enough maintainers to address every issue and pull request. This pull request has been automatically marked as |
2d525ff to
bc4f154
Compare
Member
Author
|
@phisco PTAL. I got rid of the (stale/conflicting) commit that updated some actual code, so now this is just the recommendation. I figure this is a step in the right direction at least. |
Fixes crossplane#4514 See that issue for discussion and context. Signed-off-by: Nic Cope <nicc@rk0n.org>
phisco
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #4514
See that issue for discussion and context.
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR, if necessary.Opened a PR updating the docs, if necessary.