-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[v2] Propagate internal/xresource changes back to crossplane-runtime #6505
Copy link
Copy link
Closed
crossplane/crossplane-runtime
#849Labels
Milestone
Description
What problem are you facing?
As part of the Crossplane v2 preview work I copied pkg/resource/unstructured from crossplane-runtime to internal/xresource in crossplane. I did this because:
- I wanted to move fast
- I thought only crossplane consumed this package
It seemed like there was no reason for the package to live in crossplane-runtime. Being there was only slowing down working on crossplane. I was planning to deprecate and remove pkg/resource/unstructured from runtime.
However it turns out @jcogilvie would like to use these types in https://github.com/crossplane-contrib/crossplane-diff.
How could Crossplane help solve your problem?
Given we now know of two repos that want to use these types I think we can keep them in crossplane-runtime. So I think we should drop internal/xresource and copy the changes back to pkg/resource/unstructured.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Done