Skip to content

Can't stop composed resource watches when XRD is deleted #6396

Closed
#6395
Closed
Can't stop composed resource watches when XRD is deleted#6396
#6395
Assignees
negz
Labels
bugSomething isn't workingcompositione2erealtime-composition
Milestone
v1.20
@negz

Description

@negz
negz
opened on Apr 22, 2025

What happened?

We see this in the realtime composition E2E tests a lot:

CompositeResourceDefinition/xparents.example.org cannot stop composite resource controller: cannot stop "ComposedResource" watch for "nop.crossplane.io/v1alpha1, Kind=NopResource": cannot get informer for *composed.Unstructured: Timeout: failed waiting for *composed.Unstructured Informer to sync

It's coming from:

crossplane/internal/engine/engine.go

Lines 270 to 272 in b0cc38c

if err := w.Stop(ctx); err != nil {
return errors.Wrapf(err, "cannot stop %q watch for %q", wid.Type, wid.GVK)
}

...and in turn...

crossplane/internal/engine/source.go

Lines 77 to 80 in b0cc38c

i, err := s.infs.GetInformer(ctx, s.Type)
if err != nil {
return errors.Wrapf(err, "cannot get informer for %T", s.Type)
}

Interestingly we must've been able to get the informer at some point, because we were able to start the watch:

crossplane/internal/engine/source.go

Lines 56 to 59 in b0cc38c

i, err := s.infs.GetInformer(ctx, s.Type, cache.BlockUntilSynced(true))
if err != nil {
return errors.Wrapf(err, "cannot get informer for %T", s.Type)
}

How can we reproduce it?

Delete an XRD with realtime composition enabled. It doesn't seem to happen every time, but it does happen pretty often (I reproduced it locally first attempt).

What environment did it happen in?

Crossplane version:

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingcompositione2erealtime-composition

Type

No type

Projects

Crossplane Roadmap

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions